Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More flexible conv2d_NCHWc_int8 generic operator. #6714

Merged
merged 1 commit into from
Nov 8, 2020
Merged

More flexible conv2d_NCHWc_int8 generic operator. #6714

merged 1 commit into from
Nov 8, 2020

Conversation

cbalint13
Copy link
Contributor

@cbalint13 cbalint13 commented Oct 20, 2020 •
edited
Loading

This small PR enable flexible parametrizations for conv2d_NCHWc_int8() int terms of int32_lanes and int8_elements .

Goal:

  • Allow conv2d_NCHWc_int8() to be called with any custom values of int32_lanes and int8_elements
  • Such flexibility (custom lane&elements) will be desired for future customizable ISA.

Changes:

  1. Make n_elems (default=4) optional parameter instead of static n_elems = 4 hardcode.
  2. Default fallback config now emit valid configuration for cases whenint32_lane < int8_num_elements too.
  3. All old behavior is kept, so actual Intel or ARM specific intrinsic will benefit the same default values as before.

@anijain2305 @zhiics @vinx13 @ZihengJiang please help me with the review,

Thank You !

@giuseros
Copy link
Contributor

Thanks for the explanation and for the pointers @cbalint13 ! This LGTM

@cbalint13
Copy link
Contributor Author

Thanks for the explanation and for the pointers @cbalint13 ! This LGTM

@giuseros , Thank you very much !

giuseros
giuseros approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@giuseros giuseros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know I had the possibility to approve PRs without being a "reviewer". Apparently yes :)

@vinx13
Copy link
Member

vinx13 commented Nov 7, 2020

@cbalint13 could you try restarting the CI?

@cbalint13
Copy link
Contributor Author

@cbalint13 could you try restarting the CI?

@vinx13 , done, passed.

Thank You !

@vinx13 vinx13 merged commit 5e9ddeb into apache:main Nov 8, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@cbalint13
More flexible conv2d_NCHWc_int8 generic operator. (apache#6714)
c4b97de
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@cbalint13
More flexible conv2d_NCHWc_int8 generic operator. (apache#6714)
dab8783
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@cbalint13 @trevor-m
More flexible conv2d_NCHWc_int8 generic operator. (apache#6714)
de6a58d
@junrushao junrushao mentioned this pull request Nov 1, 2021
Closed
@cbalint13 cbalint13 mentioned this pull request Jan 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseros giuseros giuseros approved these changes

@vinx13 vinx13 vinx13 approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbalint13 @giuseros @vinx13 @ZihengJiang